Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #277

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Minor fixes #277

merged 2 commits into from
Jul 4, 2023

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Jul 3, 2023 •
edited
Loading

Minor fixes:

  • Use pylint on more files and fix issues that appeared.
  • Avoid dangerous-default-value.
  • Avoid re where unneeded.

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 61.11% and project coverage change: +0.07 🎉

Comparison is base (7bfb361) 77.74% compared to head (bba29a5) 77.82%.

❗ Current head bba29a5 differs from pull request most recent head 370c0ee. Consider uploading reports for the commit 370c0ee to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   77.74%   77.82%   +0.07%     
==========================================
  Files          20       20              
  Lines        1456     1461       +5     
==========================================
+ Hits         1132     1137       +5     
  Misses        324      324
Impacted Files Coverage Δ
ocw/enums.py 68.75% <0.00%> (ø)
ocw/lib/db.py 53.03% <ø> (ø)
ocw/lib/openstack.py 77.10% <ø> (ø)
ocw/models.py 71.87% <50.00%> (ø)
ocw/views.py 57.14% <50.00%> (+1.04%) ⬆️
ocw/tables.py 70.88% <66.66%> (+1.14%) ⬆️
ocw/apps.py 75.00% <100.00%> (ø)
webui/PCWConfig.py 100.00% <100.00%> (ø)
webui/settings.py 92.10% <100.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ricardobranco777 ricardobranco777 requested review from ilausuch, asmorodskyi and grisu48 and removed request for ilausuch July 3, 2023 12:13
asmorodskyi
asmorodskyi reviewed Jul 3, 2023
View reviewed changes
pylintrc Outdated Show resolved Hide resolved
asmorodskyi
asmorodskyi reviewed Jul 3, 2023
View reviewed changes
pylintrc Outdated Show resolved Hide resolved
@ricardobranco777 ricardobranco777 added the wip Work in progress label Jul 3, 2023
@ricardobranco777 ricardobranco777 removed the wip Work in progress label Jul 3, 2023
@asmorodskyi asmorodskyi merged commit 5fa007e into SUSE:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorodskyi asmorodskyi asmorodskyi left review comments

@grisu48 grisu48 grisu48 approved these changes

@ilausuch ilausuch Awaiting requested review from ilausuch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardobranco777 @grisu48 @asmorodskyi